Switch to v6 protocol #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding support for extra milight commands
Daniel-t
reviewed
Feb 15, 2017
|
With the light |
…d bridge light, refactoring: create Milight instance when node is created instead each time, when input is received (required for "v6"), added support for effect modes (color bulb types, only), allow for picking command from either msg.command or msg.topic, updated docs, issue mwittig/node-milight-promise#21
…toring and optimization
…me place to have a more consistent behaviour among the various commands, night mode need to be sent twice with some bulb types, set longer delay between commands to produce less jitter with broadcast mode in particular
Support for "v6" bridge including support for full color bulb and bridge light
…of color space conversions. This helpful for users which use node producing hsv color values, for example, which are not supported by the color packages. See also mwittig/node-milight-promise#21 (comment)
replace usage of color package with tinycolor2
Daniel-t
approved these changes
Aug 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.